[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

[Sander de Smalen via Phabricator via cfe-commits]

sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7467
+
+  return IsZxtReturn ? Builder.CreateZExt(Load, VectorTy)
+                     : Builder.CreateSExt(Load, VectorTy);
----------------
SjoerdMeijer wrote:
> nit: and now looking at this, this can be a zero or sign extend, so `Zxt` is slightly misleading?
The default is sign-extend, so we added a flag for the case where a zero-extend is needed/expected. Are you suggesting to rename the flag or to add an extra flag for IsSxt?


================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1.c:314
+  // CHECK: @llvm.masked.store.nxv8i16.p0nxv8i16(<vscale x 8 x i16> %data, <vscale x 8 x i16>* %[[GEP]], i32 1, <vscale x 8 x i1> %{{.*}})
+  return svst1_vnum_u16(pg, base, 129, data);
+}
----------------
I can probably prune these tests a bit, when we generated these initially we also tested for code-gen, (hence the 129, which doesn't fit the immediate). This is properly tested in .ll tests in LLVM now, so I'll remove these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76238/new/

https://reviews.llvm.org/D76238