[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

[Lorenz Junglas via Phabricator via cfe-commits]

lolleko updated this revision to Diff 251334.
lolleko edited the summary of this revision.
lolleko added a comment.

Addressed review.

Paragraphs (lines separated by a double line break `\n\n`) are currently not retained. Because the current implementation of markup::Paragraph only appends a single white space after it's contents (https://github.com/llvm/llvm-project/blob/e26e9ba288ce156b851504ebbb7d8a775572957c/clang-tools-extra/clangd/FormattedString.cpp#L368).
I think this is semantically wrong because in natural language aswell as markup languages like md, html, ... a paragraph should be followed by a blank line.
But since a lot of code relies on that single white space paragraph, this should be addressed in a different patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76094/new/

https://reviews.llvm.org/D76094

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76094.251334.patch
Type: text/x-patch
Size: 8633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200319/9fbccaa5/attachment-0001.bin>