[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

Thu Mar 19 03:45:00 PDT 2020

baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.

In D76379#1929698 <https://reviews.llvm.org/D76379#1929698>, @Szelethus wrote:

> The patch looks great, though I'd kindly ask you to wait a bit for someone with a bit more experience on `SVal`-smithing ;)

Do you mean the change from `const SVal &` to `SVal`? It was done according to this comment <https://reviews.llvm.org/D73720#inline-671284>.

> Generally speaking, I think the word you are looking for is "validate", not "verify", is that right, @whisperity?

We always used the word "verify" in the iterator checkers for checking for bugs. The word "check" is reserved for the hooks, "handle" is used in the modeling. This is an internal concept for the container-iterator ecosystem, I do not know about common Clang Static Analyzer coding standard here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76379/new/

https://reviews.llvm.org/D76379