[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 16 08:42:14 PDT 2020


martong added a comment.

In D71018#1924604 <https://reviews.llvm.org/D71018#1924604>, @martong wrote:

> - Remove redundant VisitQualifiedTypeLoc and VisitAttributedTypeLoc


I realized that the mentioned functions are redundant, because we have a while loop which iterates over all related typelocs (`getNextTypeLoc`).
Also, it is better to remove the `llvm_unreachable` because there are many `TypeLoc`s that we just don't handle, e.g. `TypeOfExprTypeLoc`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71018/new/

https://reviews.llvm.org/D71018





More information about the cfe-commits mailing list