[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 15 19:52:48 PDT 2020


NoQ accepted this revision.
NoQ added a comment.

Wonderful, thank you!



================
Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:726
+            << Text;
+        return std::string(Out.str());
+      });
----------------
I suspect you can remove the explicit conversion to `std::string` given that you've specified the return type explicitly.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/DebugContainerModeling.cpp:32
 
   template <typename Getter>
   void analyzerContainerDataField(const CallExpr *CE, CheckerContext &C,
----------------
`llvm::function_ref`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75514/new/

https://reviews.llvm.org/D75514





More information about the cfe-commits mailing list