[PATCH] D75911: [clang-tidy] Added hasAnyListedName matcher

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 13 03:41:30 PDT 2020


njames93 marked an inline comment as done.
njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:53-55
+ast_matchers::internal::Matcher<NamedDecl>
+hasAnyListedName(std::vector<std::string> Names);
+
----------------
alexfh wrote:
> We could change all checks to use the other overload and drop this one (and the utils::options::parseStringList() call in each check's constructor). WDYT?
I'm not sold on that, I'd like the conventions of all checks to be the same wrt option lists, however those option lists aren't only used for names of decls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75911/new/

https://reviews.llvm.org/D75911





More information about the cfe-commits mailing list