[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

[Sander de Smalen via Phabricator via cfe-commits]

sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:86
+  OS << "#ifndef  __cplusplus\n";
+  OS << "#include <stdbool.h>\n";
+  OS << "#endif\n\n";
----------------
efriedma wrote:
> I'd prefer to avoid depending on stdbool if it isn't necessary.
Section 3.3 of the ACLE actually mentions this explicitly:
```arm_sve.h includes stdint.h and so provides standard types such as uint32_t. When included from C code the header also includes stdbool.h and so provides the bool type.```


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:92
+  OS << "typedef double float64_t;\n";
+  OS << "typedef bool bool_t;\n\n";
+
----------------
efriedma wrote:
> The ACLE documentation doesn't say anything about float16_t etc.?
In that same section, it says:
```In addition, the header file defines the following scalar data types:
  float16_t equivalent to __fp16```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75298/new/

https://reviews.llvm.org/D75298