[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

Eugene Leviant via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 12 11:57:03 PDT 2020


evgeny777 added a comment.

@pcc

> That case seems somewhat questionable to me. If the symbols are being exported, it is presumably for the purpose of allowing the symbols to be used outside of the defining DSO. But LTO visibility based optimizations could make any such use of the symbols unsafe. For example with WPD it's unsafe to derive outside of the defining DSO and with dead virtual function elimination it's unsafe to call virtual functions outside of the defining DSO.

True, but still direct (cross DSO) calls and globals accesses are possible and do not require explicitly setting visibility everywhere. That was my point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75655/new/

https://reviews.llvm.org/D75655





More information about the cfe-commits mailing list