[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 12 08:08:42 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/AST/DeclTest.cpp:125
+  auto StarLoc = TL.getStarLoc().printToString(SM);
+  ASSERT_EQ(StarLoc, "input.cc:3:12");
+}
----------------
I'd suggest to rewrite this test (and other tests in this file) to a more modern approach to testing. Specifically, I suggest that you imitate clang/unittests/Tooling/RangeSelectorTest.cpp. However, since that would be refactoring existing tests, I suggest that you do it as a follow-up change -- but please do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76061/new/

https://reviews.llvm.org/D76061





More information about the cfe-commits mailing list