[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 11 08:31:18 PDT 2020


sepavloff added inline comments.


================
Comment at: clang/include/clang/Basic/LangOptions.h:461
+  constexpr static unsigned MaxExceptionValue = 3;
+  unsigned rounding_and_exceptions: 4;
 };
----------------
There are 5 rounding directions defined by IEEE-754, which we should eventually support. Some targets supports additional rounding modes, which we might want to keep in FP environment. Existing implementation uses 3 exception behavior modes and we could want to extend them. For example it makes sense to introduce a special mode where Inexact exception is ignored but others are maintained. Four bits are too small space for FP environment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75443/new/

https://reviews.llvm.org/D75443





More information about the cfe-commits mailing list