[clang-tools-extra] 54928ba - [clang-tidy] Use more widely available headers for protability-restrict-system-includes-check's test

[Roman Lebedev via cfe-commits]

On Wed, Mar 11, 2020 at 2:54 AM Paula Toth via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
>
> Author: Paula Toth
> Date: 2020-03-10T16:54:11-07:00
> New Revision: 54928ba0ec8355edbbdb31c7b01bb45eb2d384b6
>
> URL: https://github.com/llvm/llvm-project/commit/54928ba0ec8355edbbdb31c7b01bb45eb2d384b6
> DIFF: https://github.com/llvm/llvm-project/commit/54928ba0ec8355edbbdb31c7b01bb45eb2d384b6.diff
>
> LOG: [clang-tidy] Use more widely available headers for protability-restrict-system-includes-check's test
>
> Added:
>
>
> Modified:
>     clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-allow.cpp
>     clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-disallow.cpp
>     clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-glob.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-allow.cpp b/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-allow.cpp
> index faab977ad340..e3a9376a8638 100644
> --- a/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-allow.cpp
> +++ b/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-allow.cpp
> @@ -1,9 +1,9 @@
>  // RUN: %check_clang_tidy %s portability-restrict-system-includes %t \
> -// RUN:     -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '*,-stdio.h'}]}"
> +// RUN:     -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '*,-stddef.h'}]}"
>
> -// Test block-list functionality: allow all but stdio.h.
> +// Test block-list functionality: allow all but stddef.h.
>
> -#include <stdio.h>
> -// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stdio.h not allowed
> -#include <stdlib.h>
> -#include <string.h>
> +#include <stddef.h>
> +// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stddef.h not allowed
> +#include <stdint.h>
> +#include <float.h>
In this test, are these actual system headers, or are they mocked?
Tests should not be using system headers.

> diff  --git a/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-disallow.cpp b/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-disallow.cpp
> index 58c1d4396ee5..f73cbbfc816d 100644
> --- a/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-disallow.cpp
> +++ b/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-disallow.cpp
> @@ -1,10 +1,10 @@
>  // RUN: %check_clang_tidy %s portability-restrict-system-includes %t \
> -// RUN:     -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '-*,stdio.h'}]}"
> +// RUN:     -- -config="{CheckOptions: [{key: portability-restrict-system-includes.Includes, value: '-*,stddef.h'}]}"
>
> -// Test allow-list functionality: disallow all but stdio.h.
> +// Test allow-list functionality: disallow all but stddef.h.
>
> -#include <stdio.h>
> -#include <stdlib.h>
> -// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stdlib.h not allowed
> -#include <string.h>
> -// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include string.h not allowed
> +#include <stddef.h>
> +#include <stdint.h>
> +// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include stdint.h not allowed
> +#include <float.h>
> +// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include float.h not allowed
>
> diff  --git a/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-glob.cpp b/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-glob.cpp
> index ccde9438d93c..bee7ec73438c 100644
> --- a/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-glob.cpp
> +++ b/clang-tools-extra/test/clang-tidy/checkers/portability-restrict-system-includes-glob.cpp
> @@ -4,7 +4,7 @@
>  // Test glob functionality: disallow all headers except those that match
>  // pattern "std*.h".
>
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <string.h>
> -// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include string.h not allowed
> +#include <stddef.h>
> +#include <stdint.h>
> +#include <float.h>
> +// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: system include float.h not allowed
Roman

> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits