[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

Tamás Zolnai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 7 01:06:08 PST 2020


ztamas updated this revision to Diff 248908.
ztamas added a comment.

Changed code based on reviewer comments.

- Removed unneeded allOf()
- Remove unneeded ';'
- Added new line at the end of the  file
- Moved variable declarations inside if()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75749/new/

https://reviews.llvm.org/D75749

Files:
  clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp
  clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h
  clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst
  clang-tools-extra/test/clang-tidy/checkers/bugprone-signed-char-misuse.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75749.248908.patch
Type: text/x-patch
Size: 16533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200307/521e6d37/attachment.bin>


More information about the cfe-commits mailing list