[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 6 02:46:24 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:43-45
+        llvm::errs()
+            << "Using ',' as a file extension delimiter is deprecated. Please "
+               "switch your configuration to use ';'.\n";
----------------
lebedev.ri wrote:
> Can this spam be avoided?
> It's going to be really intrusive, and it is not always possible to
> just perform the migration (think: using more than one clang-tidy version.)
> The deprecation message should be in the docs/releasenotes.
That seems like a good idea. Would take a good many versions before the comma could safely be removed without fallout so people would get the warning too often and not be able to change it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75621/new/

https://reviews.llvm.org/D75621





More information about the cfe-commits mailing list