[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 3 17:16:46 PST 2020


efriedma added a comment.

I think the specialized error messages are useful.  I don't have a strong opinion on what order the patches should land.

The difference between emitting the diagnostic in RequireCompleteType, vs. letting the caller do it, is basically just that it's harder to forget to check whether the type is sizeless.  I think that's important enough to be worth complicating the API a bit; better to forbid scalable types, rather than crash or miscompile later.  Probably the entry point that allows sizeless types should have a different name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75572/new/

https://reviews.llvm.org/D75572





More information about the cfe-commits mailing list