[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

[Nathan Ridge via Phabricator via cfe-commits]

nridge added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4972
+
+    // In T::foo::bar, `foo` must be a type.
+    bool VisitNestedNameSpecifier(NestedNameSpecifier *NNS) {
----------------
nridge wrote:
> sammccall wrote:
> > nridge wrote:
> > > It would be nice if the test exercised this case.
> > Oops, this was actually broken because VisitNestedNameSpecifier doesn't seem to be a thing :-(
> > Fixed to use TraverseNestedNameSpecifierLoc and added a test.
> > Oops, this was actually broken because VisitNestedNameSpecifier doesn't seem to be a thing :-(
> 
> (I suspected this, but the heavy macro usage in `RecursiveASTVisitor.h` made me second-guess myself and think I was just overlooking a place that defines `VisitNestedNameSpecifier`. I figured adding a test wouldn't hurt even if I'm mistaken and the code works. :-))
(Tangentially related, but a C++ editor feature I sometimes wish existed was to show a (semantically-colored and navigation-feature-enabled) //post-preprocessing// view of a source file. (But not edit that view! That would be madness.) Something to add to the backlog, perhaps.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73649/new/

https://reviews.llvm.org/D73649