[PATCH] D75056: [Driver] Default to -fno-common for all targets

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 3 09:56:28 PST 2020


MaskRay added a comment.

In D75056#1903363 <https://reviews.llvm.org/D75056#1903363>, @SjoerdMeijer wrote:

> Ha, these test-suite apps fail with `multiple definition of ...` link errors, so actually require a little bit of porting! :-)
>  But I think I will prepare a patch that adds `-fcommon` to their makefiles, as I don't want to change too many things at the same time.


Adding -fcommon looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75056/new/

https://reviews.llvm.org/D75056





More information about the cfe-commits mailing list