[PATCH] D75431: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 3 05:28:38 PST 2020


xazax.hun added a comment.

Other than a nit looks good to me but wait for @NoQ before committing.



================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:208
 
+  SValBuilder &getSValBuilder() const {
+    return State->getStateManager().getSValBuilder();
----------------
Since `SValBuilder` has relatively little to do with call events I am kind of surprised seeing this here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75431/new/

https://reviews.llvm.org/D75431





More information about the cfe-commits mailing list