[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

[Luboš Luňák via Phabricator via cfe-commits]

llunak added a comment.

In D73852#1901186 <https://reviews.llvm.org/D73852#1901186>, @rsmith wrote:

> We shouldn't enable the warning under -Wextra in language modes where there's no standard way to suppress it.


That may be true, but that is not what the bugreport is about, it explicitly mentions flex. There are codebases that explicitly use -Wimplicit-fallthrough, and flex generates the same code even for C++. So either Clang needs to handle it, or flex needs to change (which may be non-trivial if https://bugs.llvm.org/show_bug.cgi?id=43465#c24 is right), or codebases using flex will need to either special-case Clang or live with the warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73852/new/

https://reviews.llvm.org/D73852