[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 2 06:56:31 PST 2020


Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Feel free to commit as you're ready.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97
     .Case("clang_analyzer_express", &ExprInspectionChecker::analyzerExpress)
+    .StartsWith("clang_analyzer_isTainted", &ExprInspectionChecker::analyzerIsTainted)
     .Default(nullptr);
----------------
Szelethus wrote:
> xazax.hun wrote:
> > I think a comment somewhere why/when do we check only the prefix would be useful.
> This isn't done?
The documentation shows plenty of other similar debug functions, I think this patch is fine in this regard.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74131/new/

https://reviews.llvm.org/D74131





More information about the cfe-commits mailing list