[PATCH] D61549: Fix use of 'is' operator for comparison

Jens Carl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 29 09:40:30 PST 2020


j-carl added a comment.

In D61549#1785369 <https://reviews.llvm.org/D61549#1785369>, @Jim wrote:

> @j-carl Could you give a Python 3.8 syntax reference for this change.


As @tambre mentioned it's not a language change, but information about the change can be found here https://bugs.python.org/issue34850.

The problem I face with the vim integration is that vim stops the execution of the script and shows a warning:

  /usr/share/clang/clang-format.py:123: SyntaxWarning: "is not" with a literal. Did you mean "!="?                                                      
    if op[0] is not 'equal':
  Press ENTER or type command to continue

Now I have to press ENTER to get the script running. This adds another key stroke to my workflow.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61549/new/

https://reviews.llvm.org/D61549





More information about the cfe-commits mailing list