[PATCH] D75289: [clang-tidy] Added virtual isLanguageVersionSupported to ClangTidyCheck

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 28 04:59:58 PST 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:86
   /// matches occur in the order of the AST traversal.
   virtual void registerMatchers(ast_matchers::MatchFinder *Finder) {}
 
----------------
Please update the doc comment on `registerMatchers` and `registerPPCallbacks` that there is now a precondition that `isLanguageVersionSupported` must return true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75289/new/

https://reviews.llvm.org/D75289





More information about the cfe-commits mailing list