[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 26 03:42:08 PST 2020


svenvh added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:293
+- Allowed ``__private`` to be printed explicitly in diagnostics, AST, etc 
+- Fixed declaration of ``enqueue_marker``, c11 atomic fetch max/min in the
+  standard header.
----------------
Suggesting to move this item into the new section I suggested below.


================
Comment at: clang/docs/ReleaseNotes.rst:305
+- Added support for function attributes.
+FIXME: Add a sentence explaining current state?
+
----------------
Anastasia wrote:
> @svenvh Do you think we should add a sentence to summarize what is the current situation with this in rel 10?
Maybe rewrite the whole section (starting from "Changes to builtin-function inclusion with TableGen") as follows:

```
OpenCL builtin functions:
- The majority of the OpenCL builtin functions are now available through the experimental `-fdeclare-opencl-builtins` option.
- Align the `enqueue_marker` declaration in `opencl-c.h` to the OpenCL spec.
- Avoid a void pointer cast in the `CLK_NULL_EVENT` definition.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75125/new/

https://reviews.llvm.org/D75125





More information about the cfe-commits mailing list