[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 25 14:17:34 PST 2020


steven_wu added a comment.

In D74784#1891750 <https://reviews.llvm.org/D74784#1891750>, @dmajor wrote:

> @steven_wu, ping, could you clarify about the tests please?


You want to have testcase to cover all following 3 cases:

- Default (version = 0): not using -platform_version
- Old version (0 < version < 520): not using -platform_version
- New version (version >= 520): using -platform_version

It is fine to leave most of the tests with -mlinker-version=0, but you want to go into the tests of -platform_version and make sure all situations above are handled correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74784/new/

https://reviews.llvm.org/D74784





More information about the cfe-commits mailing list