[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

I am also concerned about the false positives from this check because I don't think there's going to be an easy heuristic for determining whether two identifiers are "related" to one another. There is no obvious way to silence any of the diagnostics generated as false positives short of requiring a naming convention for users to follow, which is not a particularly clean solution.

I'm not certain this is a check we should support until we solve these issues. As a use case, consider: `void draw_rect(int left_corner, int top, int right_side, int bottom_part);` -- how do we either not warn on this by default or how does the user tell us to not warn on it (without requiring them to jump through hoops like changing the types of the arguments)? I'd also want to see some data as to how often this check warns with true positives over a large, real-world code base (like LLVM).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74463/new/

https://reviews.llvm.org/D74463