[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

Thu Feb 20 09:15:45 PST 2020

xur added a comment.

In D74878#1884769 <https://reviews.llvm.org/D74878#1884769>, @serge-sans-paille wrote:

> @lebedev.ri maybe we should at least warn the user if there was a flag at clang level to force discarding? That's what I've been doing in https://reviews.llvm.org/D74871?id=245594

@serge-sans-paille
It seems to me that we are not dropping the flag of -fdiscard-value-names.  It's just the implementation of setNameImpl() that assumes the names would not be generated under this option.
In this sense, your patch is more complete as it breaks this removes this assumption.

My patch will fall back to the old behavior before Commit 60d3947922 <https://reviews.llvm.org/rG60d39479221d6bc09060f7816bcd7c54eb286603>.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74878/new/

https://reviews.llvm.org/D74878