[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 19 12:42:07 PST 2020


lebedev.ri added a comment.

In D73996#1883360 <https://reviews.llvm.org/D73996#1883360>, @erichkeane wrote:

> 1 nit, otherwise LGTM.


Thank you for the review!



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2996
+def warn_alignment_not_power_of_two : Warning<
+  "requested alignment is not a power of 2">,
+  InGroup<DiagGroup<"non-power-of-two-alignment">>;
----------------
erichkeane wrote:
> Can you use the above one (err_alignment_not_power_of_two .Text) so that they are forced to have the same message?
Oh, i always forget about that feature, thanks for pointing it out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73996/new/

https://reviews.llvm.org/D73996





More information about the cfe-commits mailing list