[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ marked 6 inline comments as done.
NoQ added inline comments.


================
Comment at: clang/tools/scan-build/bin/scan-build:953
+  my $ExitStatus = shift;
+
+  if (defined $Options{OutputFormat}) {
----------------
Charusso wrote:
> May inject `Diag "Analysis run complete.\n";` here?
Indeed!


================
Comment at: clang/tools/scan-build/bin/scan-build:976
+
+      if ($Options{ExitStatusFoundBugs}) {
+        exit 1 if ($NumBugs > 0);
----------------
Charusso wrote:
> If we stick to printing information to the user: `Diag "No bugs found.\n"`?.
We already kind of have it when it says "deleting output directory because it contains no reports".


================
Comment at: clang/tools/scan-build/bin/scan-build:1303
+   from existing report.html files. Useful for making a custom Static Analyzer
+   integration into a build system that isn't otherwise supported by scan-build.
+
----------------
Charusso wrote:
> What about `--index-only`?
Renamed to `--generate-index-only` :)


================
Comment at: clang/tools/scan-build/bin/scan-build:1618
+        DieDiag("Only one of '-o' or '--generate-index' can be specified.\n");
+      }
+
----------------
Charusso wrote:
> I may smash this duplicated error-handling above in one if-stmt, given that the options are correlate with each other.
Dunno, i'd rather keep the structure. The function is huge, i'd rather keep it well-structured, and "each option is handled in exactly once if-statement" is good for it.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74467/new/

https://reviews.llvm.org/D74467