[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 17 03:14:33 PST 2020


balazske added a comment.

In D74542#1878576 <https://reviews.llvm.org/D74542#1878576>, @teemperor wrote:

> @balazske Do you see any problems with this patch?


I have no opinion against the change. Probably sorting order of imported source locations makes not much sense (specially if recursive imports happen) and I can not tell what is the consequence of this, maybe no problem (there was something that triggered this crash, does this way of sorting order give some usable results?).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74542/new/

https://reviews.llvm.org/D74542





More information about the cfe-commits mailing list