[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 14 09:18:07 PST 2020


jdoerfert added a comment.

In D74571#1876617 <https://reviews.llvm.org/D74571#1876617>, @kkwli0 wrote:

> Thanks for all the comments.  It makes sense to keep the warning there before any ptx65 features are added.  The warning should also apply to both the CUDA and OpenMP compile paths.  As a result, I will pursue to ignore the warning in the build of libomp (i.e. libomp_check_linker_flag function in LibompCheckLinkerFlag.cmake).  I think it is less pervasive and also can avoid similar occurrence when a new version of CUDA toolkit is available.
>
> If users are annoyed by many many warning messages in the build, as @tra suggested, users can just use -Wno-unknown-cuda-version to suppress it.
>
> Comments?


That sounds like the right approach for OpenMP. We require a minimal CUDA version, based on what we use internally, but no maximal version if possible since we don't use new features anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74571/new/

https://reviews.llvm.org/D74571





More information about the cfe-commits mailing list