[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet marked 3 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98
+  case SK::TemplateTypeParm:
+  case SK::TemplateTemplateParm:
     return CompletionItemKind::Class;
----------------
hokein wrote:
> I think these two should belong to `CompletionItemKind::TypeParameter`?
right, moved the ones below but forgot to move these :D thanks!


================
Comment at: clang/lib/Index/IndexSymbol.cpp:360
       break;
+    case Decl::TemplateTypeParm:
+      Info.Kind = SymbolKind::TemplateTypeParm;
----------------
hokein wrote:
> nit: could we move these newly-added lines above the `case Decl::ClassTemplatePartialSpecialization:`. I think we usually put the `llvm_unreachable` cases at the end of switch statement..
yes but this one is specially, there's also a default label below.

Also the unreachable ones are for making sure certain `valid` types don't arrive in here rather than checking for `invalid` types are passed.
We usually put the unreachable to the end if it is protecting against invalid usages, I believe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73696/new/

https://reviews.llvm.org/D73696