[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 14 03:06:34 PST 2020


sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-index.ll:35
+; CHECK-NEXT: ret
+  %out = call <vscale x 2 x i64> @llvm.aarch64.sve.index.nxv2i64(i64 -14, i64 15)
+  ret <vscale x 2 x i64> %out
----------------
Is there a reason you're not testing for -16, 15 for all of these intrinsics? Probably better to test the edge-cases. It's also worth adding some "negative" tests for these, where the value should use the reg form instead if the immediate is not within the range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74550/new/

https://reviews.llvm.org/D74550





More information about the cfe-commits mailing list