[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 13 10:06:04 PST 2020


shafik added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:2600
+          EnumDecl *FoundDef = FoundEnum->getDefinition();
+          if (D->isThisDeclarationADefinition() && FoundDef)
+            return Importer.MapImported(D, FoundDef);
----------------
Can you explain why we need to check `D->isThisDeclarationADefinition()` 

Does the test added hit all the combination of cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74554/new/

https://reviews.llvm.org/D74554





More information about the cfe-commits mailing list