[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

Sam Parker via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 13 02:12:36 PST 2020


samparker added a comment.

How about removing Thumb-1 support until it's properly handled? I also suggest that this gets broken down a bit too, by handling the different types of function call in different patches, like getting tail-call support in first or something. Also, is this currently set to run all the time and not just when optimising for size?



================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1159
+  MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA);
+  MF.getProperties().set(MachineFunctionProperties::Property::NoPHIs);
+  MF.getProperties().set(MachineFunctionProperties::Property::NoVRegs);
----------------
Looks like these should these be set in getRequiredProperties.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57054/new/

https://reviews.llvm.org/D57054





More information about the cfe-commits mailing list