[PATCH] D74499: Remove clang::ast_type_traits namespace in favor of clang

[Reid Kleckner via Phabricator via cfe-commits]

rnk created this revision.
rnk added reviewers: bkramer, klimek, rsmith.
Herald added a project: clang.

DynTypedNode and ASTNodeKind are implemented as part of the clang AST
library, which uses the main clang namespace. There doesn't seem to be a
need for this extra level of namespacing.

I left behind aliases in the ast_type_traits namespace for out of tree
clients of these APIs. To provide aliases for the enumerators, I used
this pattern:

  namespace ast_type_traits {
  constexpr TraversalKind TK_AsIs = ::clang::TK_AsIs;
  }

I think the typedefs will be useful for migration, but we might be able
to drop these enumerator aliases. Reviewers, let me know what you think.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74499

Files:
  clang/docs/LibASTMatchersReference.html
  clang/include/clang/AST/ASTContext.h
  clang/include/clang/AST/ASTNodeTraverser.h
  clang/include/clang/AST/ASTTypeTraits.h
  clang/include/clang/AST/ParentMapContext.h
  clang/include/clang/ASTMatchers/ASTMatchFinder.h
  clang/include/clang/ASTMatchers/ASTMatchers.h
  clang/include/clang/ASTMatchers/ASTMatchersInternal.h
  clang/include/clang/ASTMatchers/Dynamic/VariantValue.h
  clang/include/clang/Tooling/ASTDiff/ASTDiff.h
  clang/include/clang/Tooling/ASTDiff/ASTDiffInternal.h
  clang/include/clang/Tooling/Refactoring/ASTSelection.h
  clang/lib/AST/ASTTypeTraits.cpp
  clang/lib/AST/ParentMapContext.cpp
  clang/lib/ASTMatchers/ASTMatchFinder.cpp
  clang/lib/ASTMatchers/ASTMatchersInternal.cpp
  clang/lib/ASTMatchers/Dynamic/Marshallers.h
  clang/lib/ASTMatchers/Dynamic/VariantValue.cpp
  clang/lib/Tooling/ASTDiff/ASTDiff.cpp
  clang/lib/Tooling/Refactoring/ASTSelection.cpp
  clang/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
  clang/lib/Tooling/Transformer/RangeSelector.cpp
  clang/lib/Tooling/Transformer/RewriteRule.cpp
  clang/lib/Tooling/Transformer/Stencil.cpp
  clang/unittests/AST/ASTContextParentMapTest.cpp
  clang/unittests/AST/ASTTraverserTest.cpp
  clang/unittests/AST/MatchVerifier.h
  clang/unittests/ASTMatchers/ASTMatchersInternalTest.cpp
  clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74499.244239.patch
Type: text/x-patch
Size: 118995 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200212/a09bacb2/attachment-0001.bin>