[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 12 04:32:24 PST 2020


hokein added a comment.

Thanks for the feedback!

Yeah, currently template classes are not supported in cross-file rename, see https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/refactor/Rename.cpp#L187.

So `llvm::Optional` and `llvm::Optional` should fail to rename, but StringRef and llvm::None should work (if you remove the hard-coded max limit 50).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71110/new/

https://reviews.llvm.org/D71110





More information about the cfe-commits mailing list