[PATCH] D74433: [llvm-objdump] Print file format in lowercase to match GNU output.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 11 13:55:40 PST 2020


MaskRay added a comment.

I think the patch is good to go on its own, after the `outs() << ":\tfile format " << O->getFileFormatName().lower() << "\n\n";` change.

If the consensus is to also change llvm-readobj output, we can teach `getFileFormatName()` to use lower case names and remove `.lower()` from llvm-objdump.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74433/new/

https://reviews.llvm.org/D74433





More information about the cfe-commits mailing list