[PATCH] D68049: Propeller: Clang options for basic block sections

[Sriraman Tallam via Phabricator via cfe-commits]

tmsriram added a comment.

>>> I think the patch series should probably be structured this way:
>>> 
>>> 1. LLVM CodeGen: enables basic block sections.
>>> 2. clang Driver/Frontend/CodeGen: pass basic block sections options to LLVM.
>>> 3. LLVM CodeGen: which enables the rest of Propeller options.
>>> 4. lld: a file similar to lld/ELF/LTO.cpp . It should be a thin wrapper of Propeller features. It should not do hacky diassembly tasks.
>>> 5. clang Driver/Frontend/CodeGen: passes compiler/linker options to 3 and 4
>>> 
>>>   Making 1 and 2 separate can help move forward the patch series. 1 and 2 should not reference `llvm::propeller`.

It is now structured like how you mentioned above.  1) corresponds to D68063 <https://reviews.llvm.org/D68063> and D73674 <https://reviews.llvm.org/D73674>.  2) corresponds to this patch, D68049 <https://reviews.llvm.org/D68049>.   These patches do not reference "propeller" anywhere and are only about basic block sections and labels.

We will address Eli's comments in the LLVM patches.  We will also make 3), 4) and 5) like how you wanted.  Further, D68065 <https://reviews.llvm.org/D68065> is about LLD support for basic block sections and will not reference "propeller".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68049/new/

https://reviews.llvm.org/D68049