[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

Thu Feb 6 18:12:24 PST 2020

rupprecht added a comment.

FYI, temporarily reverted this in fafddbd956dbe439787f6d717c247e648bb07ff5 <https://reviews.llvm.org/rGfafddbd956dbe439787f6d717c247e648bb07ff5> since it was causing failures in `Clang :: Driver/crash-report.c`. I didn't see the failure on all buildbots (otherwise I could have just marked it XFAIL), though I may have been looking in the wrong place.

Sample breakage: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/21321/steps/test-stage1-compiler/logs/stdio

Logs:

  Command Output (stderr):
  --
  /home/buildslave/ps4-buildslave1/clang-with-thin-lto-ubuntu/llvm-project/clang/test/Driver/crash-report.c:48:11: error: CHECK: expected string not found in input
  // CHECK: Preprocessed source(s) and associated run script(s) are located at:
            ^
  <stdin>:1:1: note: scanning from here
  /home/buildslave/ps4-buildslave1/clang-with-thin-lto-ubuntu/llvm-project/clang/test/Driver/crash-report.c:50:1: error: unknown type name 'BAZ'
  ^

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74070/new/

https://reviews.llvm.org/D74070