[PATCH] D74104: Remove test dependency on the presence of an assembler

[Douglas Yung via Phabricator via cfe-commits]

dyung created this revision.
dyung added a reviewer: NoQ.
dyung added a project: clang.
Herald added a subscriber: Charusso.

These tests currently call -c which requires an assembler, and will fail if your target defaults to an external assembler that is not present in the test environment. It doesn't seem like the assembler is actually needed, so just change the test to use -S instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74104

Files:
  clang/test/Analysis/scan-build/exclude_directories.test
  clang/test/Analysis/scan-build/html_output.test
  clang/test/Analysis/scan-build/plist_html_output.test
  clang/test/Analysis/scan-build/plist_output.test


Index: clang/test/Analysis/scan-build/plist_output.test
===================================================================
--- clang/test/Analysis/scan-build/plist_output.test
+++ clang/test/Analysis/scan-build/plist_output.test
@@ -5,7 +5,7 @@
 UNSUPPORTED: system-windows
 
 RUN: rm -rf %t.output_dir && mkdir %t.output_dir
-RUN: %scan-build -plist -o %t.output_dir %clang -c %S/Inputs/single_null_dereference.c \
+RUN: %scan-build -plist -o %t.output_dir %clang -S %S/Inputs/single_null_dereference.c \
 RUN:     | FileCheck %s -check-prefix CHECK-STDOUT
 
 // Test plist output
Index: clang/test/Analysis/scan-build/plist_html_output.test
===================================================================
--- clang/test/Analysis/scan-build/plist_html_output.test
+++ clang/test/Analysis/scan-build/plist_html_output.test
@@ -5,7 +5,7 @@
 UNSUPPORTED: system-windows
 
 RUN: rm -rf %t.output_dir && mkdir %t.output_dir
-RUN: %scan-build -plist-html -o %t.output_dir %clang -c %S/Inputs/single_null_dereference.c \
+RUN: %scan-build -plist-html -o %t.output_dir %clang -S %S/Inputs/single_null_dereference.c \
 RUN:     | FileCheck %s -check-prefix CHECK-STDOUT
 
 // Test combined plist and html output with -plist-html
Index: clang/test/Analysis/scan-build/html_output.test
===================================================================
--- clang/test/Analysis/scan-build/html_output.test
+++ clang/test/Analysis/scan-build/html_output.test
@@ -5,7 +5,7 @@
 UNSUPPORTED: system-windows
 
 RUN: rm -rf %t.output_dir && mkdir %t.output_dir
-RUN: %scan-build -o %t.output_dir %clang -c %S/Inputs/single_null_dereference.c \
+RUN: %scan-build -o %t.output_dir %clang -S %S/Inputs/single_null_dereference.c \
 RUN:     | FileCheck %s -check-prefix CHECK-STDOUT
 
 // Test html output
Index: clang/test/Analysis/scan-build/exclude_directories.test
===================================================================
--- clang/test/Analysis/scan-build/exclude_directories.test
+++ clang/test/Analysis/scan-build/exclude_directories.test
@@ -5,7 +5,7 @@
 UNSUPPORTED: system-windows
 
 RUN: rm -rf %t.output_dir && mkdir %t.output_dir
-RUN: %scan-build -o %t.output_dir %clang -c \
+RUN: %scan-build -o %t.output_dir %clang -S \
 RUN:     %S/Inputs/multidirectory_project/directory1/file1.c \
 RUN:     %S/Inputs/multidirectory_project/directory2/file2.c \
 RUN:     | FileCheck %s -check-prefix CHECK-NO-EXCLUDE
@@ -21,7 +21,7 @@
 
 // Only one issue should be found when directory1 is excluded.
 RUN: rm -rf %t.output_dir && mkdir %t.output_dir
-RUN: %scan-build -o %t.output_dir --exclude directory1 %clang -c \
+RUN: %scan-build -o %t.output_dir --exclude directory1 %clang -S \
 RUN:     %S/Inputs/multidirectory_project/directory1/file1.c \
 RUN:     %S/Inputs/multidirectory_project/directory2/file2.c \
 RUN:     | FileCheck %s -check-prefix CHECK-EXCLUDE1
@@ -31,7 +31,7 @@
 
 // When both directories are excluded, no issues should be reported.
 RUN: rm -rf %t.output_dir && mkdir %t.output_dir
-RUN: %scan-build -o %t.output_dir --exclude directory1 --exclude directory2 %clang -c \
+RUN: %scan-build -o %t.output_dir --exclude directory1 --exclude directory2 %clang -S \
 RUN:     %S/Inputs/multidirectory_project/directory1/file1.c \
 RUN:     %S/Inputs/multidirectory_project/directory2/file2.c \
 RUN:     | FileCheck %s -check-prefix CHECK-EXCLUDE-BOTH


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74104.242801.patch
Type: text/x-patch
Size: 3373 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200206/3d61ae23/attachment.bin>