[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

Tue Feb 4 20:02:55 PST 2020

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D73282#1856076 <https://reviews.llvm.org/D73282#1856076>, @shafik wrote:

> In D73282#1855888 <https://reviews.llvm.org/D73282#1855888>, @dblaikie wrote:
>
> > I don't think the more targeted fix is a good thing - is the same problem of not demangling names not there for the other cases that the original fix addressed?
>
>
> AFAIK no, the other cases I found via the test suite are basically compiler internals and are not real mangled names e.g.:
>
>   __omp_outlined__
>   __omp_offloading_1000008_2f4d793_main_l12_debug__
>   __cxx_global_array_dtor
>

Ah, fair enough then. Thanks for the explanation!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73282/new/

https://reviews.llvm.org/D73282