[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 4 05:01:37 PST 2020


yaxunl added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:17254
+        SourceLocation(), Context.getTranslationUnitDecl());
+  }
 
----------------
rjmccall wrote:
> Thanks, this looks a lot better.
> 
> Should this be moved to SemaOpenMP.cpp (and renamed to be OpenMP-specific), or do you think it's going to be useful in other modes?
It is not just for OpenMP. Deferred diagnostics are also emitted by CUDA/HIP.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70172/new/

https://reviews.llvm.org/D70172





More information about the cfe-commits mailing list