[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

Mon Feb 3 11:57:43 PST 2020

jkorous added a comment.

We should either simplify the implementation to reflect that we don't support e. g. `*:42` (seems preferable to me) or have the codepaths that are currently not accessible through `-fverify` tested by other means.

================
Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:206
     bool MatchAnyLine;
+    bool MatchAnyFile;

----------------
Should we rename it to `MatchAnyFileAndLine`?

================
Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:300
+                     SourceLocation ExpectedLoc, bool MatchAnyFile = false,
+                     bool MatchAnyLine = false) {
   // Construct new directive.
----------------
Should we make it clear from the interface that `MatchAnyFile` => `MatchAnyLine`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72100/new/

https://reviews.llvm.org/D72100