[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195
+
+  static const char *getTag() { return "FindLastStore"; }
+
----------------
Charusso wrote:
> I have made every tag a small-string.
This way it's harder to be sure that the tags are unique. And non-unique tags may cause terrible pain while debugging.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:203
+    ID.AddBoolean(EnableNullFPSuppression);
+  }
 };
----------------
Charusso wrote:
> I have put every Profile into the header, so it is easier to see which members are not added to the Profile. I think the root cause of https://bugs.llvm.org/show_bug.cgi?id=42938 could be some issue with differentiating between visitors.
I like this!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73520/new/

https://reviews.llvm.org/D73520