[PATCH] D73856: [docu] Improve docu of misc-misplaced-const

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 3 05:13:55 PST 2020


aaron.ballman added a comment.

> East const makes the problem more obvious. With west const people were telling me the const is on the wrong side.

I don't see how this makes the problem more obvious and it seems odd to me that we'd mix styles in code and prose. I prefer leaving this as a west const.

I have no opinion about `typedef` vs `using` in this spot, but given that the check can be used in C as well as C++, `typedef` is slightly more portable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73856/new/

https://reviews.llvm.org/D73856





More information about the cfe-commits mailing list