[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 1 01:24:21 PST 2020


njames93 added a comment.

So I tried to ran `./rename_check.py readability-braces-around-statements readability-braces` and results were less than desirable. It renamed the `readability-braces-around-statements` but it also renamed the google alias to `google-readability-braces`. In the documentation for google-readability-braces it changed the subject line to

  google-readability-braces
  ===========================================

Feel like the correct course of action is to match against the entire check name rather than a sub string of it (which i guess was unintentional). This doesn't need to be done in this review and could (should) be a follow up.

The actual alphabetical ordering of the release notes works as intended though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73580/new/

https://reviews.llvm.org/D73580





More information about the cfe-commits mailing list