[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

Fri Jan 31 08:00:18 PST 2020

hokein added a comment.

In D73780#1851654 <https://reviews.llvm.org/D73780#1851654>, @kadircet wrote:

> LG. I might be missing some context though, what's the reasoning behind? Because, I think it is not necessary to treat protobufs differently.
>
> It might be sensible to have a more generic `isSymbolFromGeneratedFile` filter, but also for this one I don't see any developments in the near future.

the motivation of this change is that we will blacklist the proto symbols for rename, we need a place to put protobuf-related functions (and we might improve clangd on better supporting protobuf symbol navigation this year) , I think it is sensible to lift them into a separate file.

================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:81
-// we check whether it starts with PROTO_HEADER_COMMENT.
-// FIXME: make filtering extensible when there are more use cases for symbol
-// filters.
----------------
kadircet wrote:
> looks like this fixme got dropped
oops..

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73780/new/

https://reviews.llvm.org/D73780