[PATCH] D73755: [objc_direct] Small updates to help with adoption.

Pierre Habouzit via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 30 17:28:34 PST 2020


MadCoder created this revision.
MadCoder added reviewers: ahatanak, dexonsmith, arphaman, erik.pilkington.
MadCoder added a project: clang.
Herald added subscribers: cfe-commits, jfb.

Add fixits for messaging self in MRR or using super, as the intent is
clear, and it turns out people do that a lot more than expected.

Allow for objc_direct_members on main interfaces, it's extremely useful
for internal only classes, and proves to be quite annoying for adoption.

Add some better warnings around properties direct/non-direct clashes (it
was done for methods but properties were a miss).

Radar-Id: rdar://problem/58355212


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73755

Files:
  clang/include/clang/Basic/Attr.td
  clang/include/clang/Basic/AttrDocs.td
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/lib/Sema/SemaDeclObjC.cpp
  clang/lib/Sema/SemaExprObjC.cpp
  clang/lib/Sema/SemaObjCProperty.cpp
  clang/test/FixIt/fixit-objc-direct.m
  clang/test/Misc/pragma-attribute-supported-attributes-list.test
  clang/test/SemaObjC/category-direct-properties.m
  clang/test/SemaObjC/method-direct.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73755.241614.patch
Type: text/x-patch
Size: 25462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200131/9a0f2efb/attachment-0001.bin>


More information about the cfe-commits mailing list