[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 30 13:15:53 PST 2020


njames93 added a comment.

I toyed with the idea of checking the access specifier for the dependent base classes, but I'm pretty sure it doesn't matter. If the compile finds 2 look ups in one base class it will pick the later dependancy regardless of whether its private or not. And if the compiler finds 2 look ups in multiple inheritance bases it will always be an error, regardless of access specifier


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73052/new/

https://reviews.llvm.org/D73052





More information about the cfe-commits mailing list