[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

Tony Tye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 29 15:02:57 PST 2020


t-tye added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:918
+  //
+  // ToDo: clang does not support CUDA/HIP dynamic parallelism, therefore
+  // CUDA/HIP kernel can be marked with norecurse. This may change in the
----------------
tra wrote:
> I believe dynamic parallelism is more like spawning a separate process, not recursion, so we should be OK.
Right, dynamic parallelism is equivalent to spawn a new thread to execute the function. Recursion is only about the same thread calling the function. So I agree that the TODO about it can be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73651/new/

https://reviews.llvm.org/D73651





More information about the cfe-commits mailing list