[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

Tue Jan 28 01:56:17 PST 2020

simon_tatham added a comment.

In D73457#1842605 <https://reviews.llvm.org/D73457#1842605>, @amccarth wrote:

> clang will still (by default) use the MS runtime libraries for Windows builds, in which case it's important for the compatibility version to match the one for the libraries that are going to be used.  I think we can/should reconsider this when clang-cl starts using different run-time libraries for Windows builds.

Ah, yes, I was half wondering if there might need to be separate options for "behave like version x of the MSVC compiler" and "expect version y of the MSVC library [or some other library, etc]". Sounds as if that's a potential future thing but not now.

In D73457#1842668 <https://reviews.llvm.org/D73457#1842668>, @aaron.ballman wrote:

> LGTM!

Thanks for the review!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73457/new/

https://reviews.llvm.org/D73457